Skip to content

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 16, 2025

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

smanilov and others added 30 commits May 30, 2025 15:48
1. Clarify that there is a single concrete type for an opaque type
2. Clarify that defining a type alias to an opaque type is an unstable feature
3. Add complete example
4. Clarify that defining an associate type as opaque is an unstable
   feature
5. Add another complete example
This file previously contained an error annotation with incorrect syntax.
Remove this annotation, as per the dev guide, since this is marked as known-bug.
https://rustc-dev-guide.rust-lang.org/tests/ui.html#known-bugs
Co-authored-by: Tshepang Mbambo <hopsi@tuta.io>
…ions

Remove `[no-mentions]` handler in our triagebot config
Signed-off-by: xiaolinny <xiaolincode@outlook.com>
Mention sharing the solver with rust-analyzer
Fix broken link for 'Uniqueness and Reference Immutability'
fix help wanted search
Update opaque-types-type-alias-impl-trait.md
rustc-dev-guide subtree update

Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@326e590.

Created using https://github.com/rust-lang/josh-sync.

r? `@ghost`
…y, r=Kivooeo

Remove deny of manual-let-else

During discussion on Zulip[^1], we found there was no strong consensus in favor of this in practice.

[^1]: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/.60deny.28clippy.3A.3Amanual_let_else.29.60.20proliferation/with/564085588
…bjorn3

std: io: error: Add comment for UEFI unpacked repr use

The following commit adds the comment explaining the rational why UEFI uses unpacked representation on 64-bit platforms as opposed to bit-packed representation used in all other 64-bit platforms.

r? `@bjorn3`
@rustbot rustbot added A-CI Area: Our Github Actions CI A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 16, 2025
@JonathanBrouwer
Copy link
Contributor Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Dec 16, 2025

📌 Commit ff84058 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2025
@bors
Copy link
Collaborator

bors commented Dec 16, 2025

⌛ Testing commit ff84058 with merge 2dc3024...

@bors
Copy link
Collaborator

bors commented Dec 17, 2025

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 2dc3024 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2025
@bors bors merged commit 2dc3024 into rust-lang:main Dec 17, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 17, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 31010ca (parent) -> 2dc3024 (this PR)

Test differences

Show 478 test diffs

Stage 1

  • [ui] tests/ui/borrowck/return-ref-to-temporary.rs: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/branch-protection-missing-pac-ret.rs#BADFLAGS: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/branch-protection-missing-pac-ret.rs#BADFLAGSPC: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/crate-type-flag.rs#cdylib: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/crate-type-flag.rs#multivalue_combined: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/crate-type-flag.rs#rlib: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/crate-type-flag.rs#staticlib: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/function-return/thunk-extern-requires-non-large-code-model.rs#medium: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/indirect-branch-cs-prefix/requires-x86-or-x86_64.rs#x86: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/indirect-branch-cs-prefix/requires-x86-or-x86_64.rs#x86_64: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/print-file-names-request-malformed-crate-name-1.rs: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/print-file-names-request-malformed-crate-name.rs: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/print-without-arg.rs: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/regparm/regparm-valid-values.rs#regparm1: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/regparm/regparm-valid-values.rs#regparm3: [missing] -> pass (J0)
  • [ui] tests/ui/compile-flags/invalid/regparm/requires-x86.rs#aarch64: [missing] -> pass (J0)
  • [ui] tests/ui/fmt/println-float.rs: [missing] -> pass (J0)
  • [ui] tests/ui/indexing/ref-array-indexing.rs: [missing] -> pass (J0)
  • [ui] tests/ui/invalid-compile-flags/crate-type-flag.rs#bin: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/crate-type-flag.rs#dylib: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/crate-type-flag.rs#multivalue: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/crate-type-flag.rs#staticlib: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/debug-option-without-group.rs: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/function-return/requires-x86-or-x86_64.rs#x86: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/function-return/thunk-extern-requires-non-large-code-model.rs#large: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/invalid-llvm-passes.rs: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/need-crate-arg-ignore-tidy$x.rs: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/print-file-names-request-malformed-crate-name-2.rs: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/reg-struct-return/requires-x86.rs#aarch64: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/regparm/regparm-valid-values.rs#regparm1: pass -> [missing] (J0)
  • [ui] tests/ui/invalid-compile-flags/regparm/requires-x86.rs#aarch64: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-16783.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17933.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-19398.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-19499.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-19734.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-20162.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-22644.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-23189.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-24945-repeat-dash-opts.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-34047.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-3656.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-43205.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-46472.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-50442.rs: pass -> [missing] (J0)
  • [ui] tests/ui/lint/lint-missing-doc-crate-flags.rs: [missing] -> pass (J0)
  • [ui] tests/ui/lint/lint-missing-doc-crate.rs: pass -> [missing] (J0)
  • [ui] tests/ui/parser/cast-angle-bracket-precedence.rs: [missing] -> pass (J0)
  • [ui] tests/ui/shadowed/match-binding-shadows-const.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/compile-flags/invalid/reg-struct-return/requires-x86.rs#aarch64: [missing] -> pass (J1)
  • [ui] tests/ui/compile-flags/invalid/regparm/regparm-valid-values.rs#regparm2: [missing] -> pass (J1)
  • [ui] tests/ui/compile-flags/invalid/regparm/regparm-valid-values.rs#regparm3: [missing] -> pass (J1)
  • [ui] tests/ui/compile-flags/invalid/regparm/regparm-valid-values.rs#regparm4: [missing] -> pass (J1)
  • [ui] tests/ui/invalid-compile-flags/function-return/requires-x86-or-x86_64.rs#aarch64: pass -> [missing] (J1)
  • [ui] tests/ui/invalid-compile-flags/reg-struct-return/requires-x86.rs#aarch64: pass -> [missing] (J1)
  • [ui] tests/ui/invalid-compile-flags/regparm/regparm-valid-values.rs#regparm1: pass -> [missing] (J1)
  • [ui] tests/ui/invalid-compile-flags/regparm/regparm-valid-values.rs#regparm3: pass -> [missing] (J1)
  • [ui] tests/ui/invalid-compile-flags/regparm/requires-x86.rs#x86_64: pass -> [missing] (J1)
  • [ui] tests/ui/any/try_as_dyn.rs: [missing] -> pass (J2)
  • [ui] tests/ui/any/try_as_dyn_soundness_test2.rs: [missing] -> pass (J2)
  • [ui] tests/ui/closures/closure-upvar-trait-caching.rs: [missing] -> pass (J2)
  • [ui] tests/ui/compile-flags/invalid/crate-type-flag.rs#bin: [missing] -> pass (J2)
  • [ui] tests/ui/compile-flags/invalid/crate-type-flag.rs#lib: [missing] -> pass (J2)
  • [ui] tests/ui/compile-flags/invalid/crate-type-flag.rs#staticlib: [missing] -> pass (J2)
  • [ui] tests/ui/compile-flags/invalid/function-return/thunk-extern-requires-non-large-code-model.rs#kernel: [missing] -> pass (J2)
  • [ui] tests/ui/compile-flags/invalid/need-crate-arg-ignore-tidy$x.rs: [missing] -> pass (J2)
  • [ui] tests/ui/compile-flags/invalid/print-file-names-request-malformed-crate-name-2.rs: [missing] -> pass (J2)
  • [ui] tests/ui/compile-flags/invalid/print-file-names-request-malformed-crate-name.rs: [missing] -> pass (J2)
  • [ui] tests/ui/compile-flags/invalid/print.rs: [missing] -> pass (J2)
  • [ui] tests/ui/enum/enum-variant-no-field.rs: [missing] -> pass (J2)
  • [ui] tests/ui/enum/enum-with-uninhabited-variant.rs: [missing] -> pass (J2)
  • [ui] tests/ui/invalid-compile-flags/branch-protection-missing-pac-ret.rs#BADFLAGS: pass -> [missing] (J2)
  • [ui] tests/ui/invalid-compile-flags/crate-type-flag.rs#staticlib: pass -> [missing] (J2)
  • [ui] tests/ui/invalid-compile-flags/crate-type-flag.rs#unknown: pass -> [missing] (J2)
  • [ui] tests/ui/invalid-compile-flags/emit-output-types-without-args.rs: pass -> [missing] (J2)
  • [ui] tests/ui/invalid-compile-flags/print-file-names-request-malformed-crate-name-1.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-17001.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-17758.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-17933.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-18159.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-18532.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-21177.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-21291.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-21449.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-23189.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-27033.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-34047.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-49854.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-50442.rs: pass -> [missing] (J2)
  • [ui] tests/ui/lint/lint-missing-doc-crate-flags.rs: [missing] -> pass (J2)
  • [ui] tests/ui/moves/array-copy-move.rs: [missing] -> pass (J2)
  • [ui] tests/ui/statics/static-mut-unsafe-init.rs: [missing] -> pass (J2)
  • [ui] tests/ui/threads-sendsync/thread-join-unwrap.rs: [missing] -> pass (J2)
  • [ui] tests/ui/trait-bounds/sort-missing-ord-bound.rs: [missing] -> pass (J2)
  • [ui] tests/ui/typeck/missing-type-annotation.rs: [missing] -> pass (J2)
  • [ui] tests/ui/compile-flags/invalid/function-return/requires-x86-or-x86_64.rs#x86_64: [missing] -> ignore (gcc backend is marked as ignore) (J3)
  • [ui] tests/ui/invalid-compile-flags/indirect-branch-cs-prefix/requires-x86-or-x86_64.rs#x86_64: ignore (gcc backend is marked as ignore) -> [missing] (J3)
  • [ui] tests/ui/invalid-compile-flags/regparm/regparm-valid-values.rs#regparm0: ignore (gcc backend is marked as ignore) -> [missing] (J3)
  • [ui] tests/ui/compile-flags/invalid/crate-type-flag.rs#cdylib: [missing] -> pass (J4)
  • [ui] tests/ui/invalid-compile-flags/crate-type-flag.rs#cdylib: pass -> [missing] (J4)

(and 272 additional test diffs)

Additionally, 106 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2dc30247c5d8293aaa31e1d7dae2ed2fde908ada --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 10149.6s -> 7922.2s (-21.9%)
  2. x86_64-gnu-llvm-21-3: 6938.1s -> 8451.9s (+21.8%)
  3. dist-x86_64-llvm-mingw: 8292.1s -> 7331.3s (-11.6%)
  4. x86_64-gnu-llvm-20: 4408.2s -> 4865.8s (+10.4%)
  5. pr-check-2: 2441.5s -> 2690.6s (+10.2%)
  6. x86_64-gnu-llvm-21-2: 5637.2s -> 6172.4s (+9.5%)
  7. dist-aarch64-llvm-mingw: 6373.1s -> 5774.4s (-9.4%)
  8. dist-android: 1671.5s -> 1518.8s (-9.1%)
  9. dist-x86_64-netbsd: 5302.5s -> 4892.1s (-7.7%)
  10. x86_64-gnu-miri: 4749.5s -> 5104.8s (+7.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#147939 Make const BorrowMut require const Borrow and make `con… e484ef6fb9467cc2c39a72e738c235f3b5aed24a (link)
#149734 Mirror GCC 9.5.0 eaf1f3495779fb9197ddf33e0c519e197f4e0cb5 (link)
#149767 Tidying up tests/ui/issues 33 tests [4/N] 62e6a2f76cc70b4cb5771e2156ecc63f2b7a65ac (link)
#149804 chore: fix some minor issues in the comments af61616837cfa4c43acf6d5c725835dda35032fd (link)
#149967 custom VaList layout for Hexagon 54bc91a7f8b511009010f01d4a77620605cce3bf (link)
#150025 dont create unnecessary DefIds under mgca 95500cf2b28241f18161096d7a6cd46189f493c9 (link)
#150032 Use annotate-snippet as default emitter on stable 0257caab7b8141d01ebabfd14f1401893a5677f8 (link)
#150033 Add try_as_dyn and try_as_dyn_mut a940df30b15a09fbbdd0e3d3e1b137e2f7ef4801 (link)
#150042 rustc-dev-guide subtree update 7c7400a97bf466adbecb50737cab6eab764f894f (link)
#150063 Remove deny of manual-let-else f2fed7b4ea7b2d28fe413eb12c298407d104fed7 (link)
#150064 std: io: error: Add comment for UEFI unpacked repr use 8a2a6ab03fcfbe030b808591e8a500923f7a1beb (link)

previous master: 31010ca61c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2dc3024): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.1% [4.1%, 4.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary -2.2%, secondary 6.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.3% [3.5%, 9.2%] 2
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.038s -> 482.354s (0.69%)
Artifact size: 390.32 MiB -> 390.55 MiB (0.06%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.